fix: Add trim to searchValue in OptionsUtils#6993
Merged
mountiny merged 1 commit intoJan 3, 2022
Merged
Conversation
MelvinBot
requested review from
mountiny and
parasharrajat
and removed request for
a team
mountiny
requested changes
Jan 3, 2022
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
@mananjadhav Thank you very much for the PR! I have one request, would you be able to show a screenshot/video, with a new email searched? Email the user has never been in touch and maybe does not even exist (I think that was the case in the original proposal)
Collaborator
Author
|
@mountiny Updated in the PR body web screenshot. |
mountiny
approved these changes
Jan 3, 2022
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
@mananjadhav Thank you! Nice job on this issue:)
Contributor
45 tasks
Contributor
|
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
trim()forOptionsUtilsso that leading/trailing spaces can be ignored when making the search calls.Fixed Issues
$ #6907
Tests
QA Steps
Tested On
Screenshots
Web
New Email Search
Mobile Web
Desktop
iOS
Android